[RFC PATCH] xfs: pass KM_SLEEP flag to kmem_realloc() in xlog_recover_add_to_cnt_trans()

Ben Myers bpm at sgi.com
Tue Jan 31 11:50:53 CST 2012


On Fri, Jan 27, 2012 at 03:37:26PM +0900, Mitsuo Hayasaka wrote:
> The kmem_realloc() in xfs is given KM_* memory allocation flags. And it
> allocates memory using kmalloc() after they are converted to gfp_mask
> flags. In xlog_recover_add_to_cont_trans(), 0u is passed to kmem_realloc(),
> instead of them. I guess it is preferred to use them, and here memory must
> be allocated but don't have to be done with GFP_ATOMIC. So, this patch
> changes it to KM_SLEEP.
> 
> Signed-off-by: Mitsuo Hayasaka <mitsuo.hayasaka.hu at hitachi.com>
> Cc: Ben Myers <bpm at sgi.com>
> Cc: Alex Elder <elder at kernel.org>
> Cc: Christoph Hellwig <hch at lst.de>

Looks good.  Consistent with other kmem_*alloc in log recovery.

Reviewed-by: Ben Myers <bpm at sgi.com>



More information about the xfs mailing list