[patch 02/12] xfs: do exact log space wakeups in xlog_ungrant_log_space

Mark Tinguely tinguely at sgi.com
Tue Jan 17 16:42:33 CST 2012


On 01/-10/63 13:59, Christoph Hellwig wrote:
> The only reason that xfs_log_space_wake had to do opportunistic wakeups
> was that the old xfs_log_move_tail calling convention didn't allow for
> exact wakeups when not updating the log tail LSN.  Since this issue has
> been fixed we can do exact wakeups now.
>
> Signed-off-by: Christoph Hellwig<hch at lst.de>
>
> ---
>   fs/xfs/xfs_log.c |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> Index: xfs/fs/xfs/xfs_log.c
> ===================================================================
> --- xfs.orig/fs/xfs/xfs_log.c	2011-12-11 15:30:49.977750776 +0100
> +++ xfs/fs/xfs/xfs_log.c	2011-12-11 17:49:00.692836117 +0100
> @@ -2748,7 +2748,7 @@ xlog_ungrant_log_space(xlog_t	     *log,
>
>   	trace_xfs_log_ungrant_exit(log, ticket);
>
> -	xfs_log_space_wake(log->l_mp, true);
> +	xfs_log_space_wake(log->l_mp, false);
>   }
>
>   /*
>

It make sense that xlog_ungrant_log_space() does not need to do 
opportunistic wakeup.

Reviewed-by: Mark Tinguely <tinguely at sgi.com>




More information about the xfs mailing list