Why does xfsdump encounter "WARNING: could not get list of non-root attributes for nondir ino nnnn: Cannot allocate memory (12)"?

Dave Chinner david at fromorbit.com
Wed Jan 11 04:14:27 CST 2012


On Wed, Jan 11, 2012 at 05:04:12AM -0500, Christoph Hellwig wrote:
> On Wed, Jan 11, 2012 at 09:03:16PM +1100, Dave Chinner wrote:
> > Sounds like a generic kvmalloc()/kvfree() call pair is the answer
> > then. i.e. if kmalloc fails, then use vmalloc()...
> 
> If my memory serves me right that's been discussed and rejected a few
> times before.

Which has lead to several implementations of duplicated
functionality like:

	- ext4_kvmalloc/ext4_kvfree
	- drm_malloc_ab/drm_calloc_large/drm_free_large
	- ceph_buffer_new/ceph_buffer_release
	- gfs2_alloc_sort_buffer/gfs2_free_sort_buffer
	- __ntfs_malloc/ntfs_free

I don't think adding another two sets of identical wrappers (or open
coding it) is the right thing given that it is a repeating pattern.

Cheers,

Dave.
-- 
Dave Chinner
david at fromorbit.com




More information about the xfs mailing list