[PATCH 6/8] xfs: make xfs_inode_item_size idempotent

Christoph Hellwig hch at infradead.org
Tue Feb 28 05:08:58 CST 2012


On Tue, Feb 21, 2012 at 04:14:04PM +1100, Dave Chinner wrote:
> One minor cleanup:
> 
> >  	case XFS_DINODE_FMT_LOCAL:
> > -		ASSERT(!(iip->ili_format.ilf_fields &
> > -			 (XFS_ILOG_ABROOT | XFS_ILOG_AEXT)));
> > -		if (iip->ili_format.ilf_fields & XFS_ILOG_ADATA) {
> > +		iip->ili_format.ilf_fields &=
> > +			~(XFS_ILOG_AEXT | XFS_ILOG_ABROOT);
> > +
> > +		if ((iip->ili_format.ilf_fields & XFS_ILOG_ADATA) &&
> > +		    ip->i_afp->if_bytes > 0) {
> >  			ASSERT(ip->i_afp->if_bytes > 0);
> 
> That assert can go - it's checked in the if statement now.

Fixed.



More information about the xfs mailing list