[PATCH 4/4] V2 xfs: fix deadlock in xfs_rtfree_extent with kernel v2.6.37
Christoph Hellwig
hch at infradead.org
Sat Feb 25 03:40:30 CST 2012
On Thu, Feb 23, 2012 at 08:52:57AM -0800, Kamal Dasu wrote:
>
> To fix the deadlock caused by recursively calling xfs_rtfree_extent
> from xfs_bunmapi():
>
> - removed xfs_trans_iget() from xfs_rtfree_extent(),
> instead added asserts that the inode is locked and has an inode_item
> attached to it.
> - in xfs_bunmapi() when dealing with an inode with the rt flag
> call xfs_ilock() and xfs_trans_ijoin() so that the
> reference count is bumped on the inode and attached it to the
> transaction before calling into xfs_bmap_del_extent, similar to
> what we do in xfs_bmap_rtalloc.
>
> Signed-off-by: Kamal Dasu <kdasu.kdev at gmail.com>
This looks good, thanks a lot!
Do you have an easily reproducable testcase for this which we could
put into xfstests?
More information about the xfs
mailing list