[PATCH 12/12] xfs: split and cleanup xfs_log_reserve

Mark Tinguely tinguely at sgi.com
Tue Feb 21 09:18:04 CST 2012


On 02/19/12 20:31, Christoph Hellwig wrote:
> Split the log regrant case out of xfs_log_reserve into a separate function,
> and merge xlog_grant_log_space and xlog_regrant_write_log_space into their
> respective callers.  Also replace the XFS_LOG_PERM_RESERV flag, which easily
> got misused before the previous cleanups with a simple boolean parameter.
>
> Reviewed-by: Ben Myers<bpm at sgi.com>
> Signed-off-by: Christoph Hellwig<hch at lst.de>
>
> ---
>   fs/xfs/xfs_log.c   |  198 ++++++++++++++++++++++++-----------------------------
>   fs/xfs/xfs_log.h   |    1
>   fs/xfs/xfs_trace.h |    1
>   fs/xfs/xfs_trans.c |   17 +++-
>   4 files changed, 103 insertions(+), 114 deletions(-)

Sorry for the omission. The clean up looks good.

Reviewed-by: Mark Tinguely <tinguely at sgi.com>



More information about the xfs mailing list