[PATCH 2/9] xfs: use per-filesystem radix trees for dquot lookup

Christoph Hellwig hch at infradead.org
Fri Feb 17 11:38:24 CST 2012


On Thu, Feb 16, 2012 at 09:21:11AM +1100, Dave Chinner wrote:
> qi->qi_tree_lock, as the local variable is already set up.

Indeed.

> > +	struct radix_tree_root *tree = XFS_DQUOT_TREE(mp, type);
> > +	struct xfs_dquot	*dqp;
> > +	int			error;
> 
> Add a quotainfo local variable and use it in the function?

Yes, that's a good idea.

> qi->qi_tree_lock as it is already there and used for all the other
> quotainfo references.

Indeed.

I've fixed all these up, and also changed the XFS_DQUOT_TREE macro
to take a quotainfo pointer instead of a mount pointer.



More information about the xfs mailing list