[PATCH] repair: fix incorrect use of thread local data in dir and attr code

Dave Chinner david at fromorbit.com
Tue Feb 7 22:13:53 CST 2012


On Tue, Feb 07, 2012 at 12:54:00PM -0500, Christoph Hellwig wrote:
> The attribute and dirv1 code use pthread thread local data incorrectly in
> a few places, which will make them fail in horrible ways when using the
> ag_stride options.
> 
> Replace the use of thread local data with simple local allocations given
> that there is no needed to micro-optimize these allocations as much
> as e.g. the extent map.  The added benefit is that we have to allocate
> less memory, and can free it quickly.
> 
> Reported-by: Tom Crane <T.Crane at rhul.ac.uk>
> Tested-by: Tom Crane <T.Crane at rhul.ac.uk>
> Signed-off-by: Christoph Hellwig <hch at lst.de>

Looks pretty sane to me. Especially as the comments suggest it never
even worked correctly in the first place.

Reviewed-by: Dave Chinner <dchinner at redhat.com>

Cheers,

Dave.
-- 
Dave Chinner
david at fromorbit.com



More information about the xfs mailing list