[PATCH] xfsdump: fill in missing strerror() call

Alex Elder elder at inktank.com
Wed Dec 26 16:25:19 CST 2012


Nigel Tamplin reported getting a seg fault in xfsrestore when a path
name was too long.

Based on the surrounding code, I'm sure strerror(errno) was the
intended final argument to this call.  This bug has been there
since the code was first committed.

Signed-off-by: Alex Elder <elder at inktank.com>
Reported-by: Nigel Tamplin <ntamplin at codefaber.co.uk>
---
 restore/content.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/restore/content.c b/restore/content.c
index edd00ed..4e55a76 100644
--- a/restore/content.c
+++ b/restore/content.c
@@ -7799,7 +7799,8 @@ restore_spec( filehdr_t *fhdrp, rv_t *rvp, char
*path )
 				      "%s ino %llu %s: %s: discarding\n"),
 				      printstr,
 				      fhdrp->fh_stat.bs_ino,
-				      path );
+				      path,
+				      strerror( errno ));
 				( void )close( sockfd );
 				return BOOL_TRUE;
 			}
-- 
1.7.9.5



More information about the xfs mailing list