[PATCH] xfs: minor inode64 mount option cleanup

Christoph Hellwig hch at infradead.org
Fri Aug 17 07:23:29 CDT 2012


> @@ -295,12 +295,13 @@ xfs_parseargs(
>  			}
>  			dswidth = simple_strtoul(value, &eov, 10);
>  		} else if (!strcmp(this_char, MNTOPT_64BITINODE)) {
> +#if XFS_BIG_INUMS
>  			mp->m_flags &= ~XFS_MOUNT_SMALL_INUMS;
> -#if !XFS_BIG_INUMS
> +#else /* !XFS_BIG_INUMS */

Looks good for now, but in the long run I'd prefer thast XFS simplify
requires 64-bit block numbers like gfs2 as there's not too much of a
point using it in a super-constrained envrionment and we could kill
all the XFS_BIG_INUMS conditionals, as well as the types that are
different based on the in-memory block number size.



More information about the xfs mailing list