[PATCH 1/4] xfstests: test 110 sometimes fails to unmount scratch dev

Rich Johnston rjohnston at sgi.com
Thu Aug 16 14:16:19 CDT 2012


On 07/26/2012 03:35 AM, Dave Chinner wrote:
> From: Dave Chinner <dchinner at redhat.com>
>
> It runs a bunch of rm processes in the background, then immediately
> calls _check_scratch_fs without waiting for them to complete, hence
> the unmount can fail with a busy filesystem error.
>
> Signed-off-by: Dave Chinner <dchinner at redhat.com>
> ---
>   110 |    1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/110 b/110
> index aad5835..c58e6c9 100755
> --- a/110
> +++ b/110
> @@ -69,6 +69,7 @@ do
>       let I=$I+1
>       [ $[$I % 1000] -eq 0 ] && echo "Created $I/$E"
>   done
#RCJ Yes wait for rm processes to complete
> +wait
>
>   sync
>
>
Looks good to me.

Reviewed-by: Rich Johnston <rjohnston at sgi.com>



More information about the xfs mailing list