[PATCH 34/37] xfs: clean up xfs_bit.h includes

Christoph Hellwig hch at infradead.org
Sun Apr 29 16:55:25 CDT 2012


>   * Visible inode allocation functions.
>   */
> +/*
> + * Find a free (set) bit in the inode bitmask.
> + */
> +static inline int xfs_ialloc_find_free(xfs_inofree_t *fp)
> +{
> +	return xfs_lowbit64(*fp);
> +}

I'd suggest killing this helper entirely - there is just a single
caller, and using the lowbit helper directly actually is even more
obvious.



More information about the xfs mailing list