[PATCH] disable tags in post-receive hook

Russell Cattelan cattelan at thebarn.com
Thu Apr 12 11:15:40 CDT 2012


On 4/12/12 3:49 AM, Stan Hoeppner wrote:
> On 4/11/2012 11:26 AM, Ben Myers wrote:
>> Hey Folks,
>>
>>     Yesterday I pushed tags to the oss.sgi.com xfs git repository and forgot to
>>     disable the post-receive hook which generates email to the list at commit
>>     time.  You probably saw the resulting mailbomb.  I'm sorry about that.  In
>>     order to make sure it doesn't happen again next time, I have applied the
>>     following patch to our post-receive hook:
> 
> I curse you for the error Ben and praise you for this correction.
> Mailman unsubbed me sometime yesterday according to a subject line.
> There was no body, no reason give.  But, I know the cause.
> 
> I was limiting concurrent SMTP connections to 1 to fight runaway bots.
> Was working great until this bombing run.  The OSS list server runs
> Sendmail, which is dumb and opens a new connection for every message
> delivery.  This behavior can potentially bring an MX to its knees due to
> smtpd process starvation.
Hmm yes and no.
There was some config issues with with queues on oss that hopefully I
have significantly improved. Sendmail does do connection caching and
will deliver as much mail as possible on the same connection as
possible. The problem was that the queue runnners was set to 400 runners
which was essentially was causing oss to grind itself into the ground
and causing enough delays that most connection caches where probably
timing out.

Also the queue sorting has been changed from the default "priority" sort
which basically will be a time sort in this case to "host" sort which
will try to optimize envelope address delivery. For a mail list server
this should be a significant win since it should be able to better take
advantage of the connection cache. (especially when "tag" bombs happen).

The queue run time has been changed from the default of 30m to 1m which
should cut the mail list delays down significantly.

Changed the drive queue scheduler from cfq to deadline

I've been watching the headers since the change and the turn around
times for mail leaving the originating host to landing in my mail server
is about 1 - 2 min. Occasionally there is a delay on sgi's barracuda box
but that is whole other box of worms.

Please send me any observations  + or - so I know if the tuning is
headed in the right direction.

-Russell

> 
> Postfix on the other hand will open one connection and keep sending
> until all mail queued for the destination MX has been sent, or until
> there is more than a 2 second delay between deliveries.
> 
> I understand Brent Bice of SGI is building an 'evidence file' to justify
> a rebuild of OSS to use Postfix and the latest Mailman.  Maybe you could
> lend your support or blessing.
Heh another can of worms :-)

> 
> The current OSS list server has other problems as well, including large
> delays between receiving posts and sending them back out.  I'm assuming
> I'm not the only one to notice this.
> 
> Thanks.
> 

-------------- next part --------------
A non-text attachment was scrubbed...
Name: cattelan.vcf
Type: text/x-vcard
Size: 277 bytes
Desc: not available
URL: <http://oss.sgi.com/pipermail/xfs/attachments/20120412/6c322bbb/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 259 bytes
Desc: OpenPGP digital signature
URL: <http://oss.sgi.com/pipermail/xfs/attachments/20120412/6c322bbb/attachment.sig>


More information about the xfs mailing list