[PATCH] 273: don't delete everything if $SCRATCH_MNT isn't set

[Bryan Schumaker]

On 04/11/12 16:04, Christoph Hellwig wrote:

> On Tue, Apr 10, 2012 at 07:44:45AM +1000, Dave Chinner wrote:
>> On Mon, Apr 09, 2012 at 02:36:21PM -0400, Bryan Schumaker wrote:
>>> The cleanup function is trapped before _require_scratch() is called, and
>>> then expands "rm -rf $SCRATCH_MNT/*" to "rm -rf /*"
>>
>> It doesn't need to clean up the scratch device - tests need to mkfs
>> it first before using it, so just remove the $tmp* files. The sae
>> fix is needed for tests 274 and 275.
> 
> Given his address I assume Bryan might test on NFS, which has funky
> semantics for the scratch device.
> 
> Is that true Bryan?  I really need to dive back into how we handle NFS
> in this respect to have a good judgement on this patch.
> 


Yeah, I'm testing on NFS (I guess the netapp address is a bit of a giveaway...).  I don't think this test runs on NFS, but if the scratch variables are unset then it'll still delete the root directory of the NFS client.

- Bryan