Looks good in general, but I'd be tempted to say the semantics changes to xfs_trans_read_buf should be a separate patch from killing xfs_read_buf. Either way: Reviewed-by: Christoph Hellwig <hch at lst.de>