[PATCH 23/27] rearrange bmapi and bmalloca structures for best packing

Christoph Hellwig hch at infradead.org
Wed Sep 21 09:06:03 CDT 2011


On Mon, Sep 19, 2011 at 10:52:27AM -0500, Alex Elder wrote:
> On Sun, 2011-09-18 at 16:41 -0400, Christoph Hellwig wrote:
> > plain text document attachment (xfs-bmalloca-shrink)
> > Minimise the stack overhead of the remaining stack variables and
> > structures placed on the stack by packing them without holes. pahole
> > is used to optimise allocation args structures, stack variables are
> > done manually.
> > 
> > [hch: various updates while forward porting the changes]
> > 
> > Signed-off-by: Dave Chinner <dchinner at redhat.com>
> > Signed-off-by: Christoph Hellwig <hch at lst.de>
> 
> I don't object to it, but I do comment on something
> below that I think is not an improvement.  I'll
> take this as-is anyway, unless you care to re-submit
> it.

This one actually breaks test 170, so I'd suggest skipping it for now.
All the later patches will apply just fine without it.




More information about the xfs mailing list