[PATCH] xfsdump: remove redundant error code mapping
Bill Kendall
wkendall at sgi.com
Mon Sep 19 16:31:34 CDT 2011
On 09/19/2011 04:02 PM, Alex Elder wrote:
> On Fri, 2011-09-02 at 09:22 -0500, Bill Kendall wrote:
>> Currently there is both an exit_strings array and an exit_codestring()
>> function for mapping an exit code to a string. They are very similar
>> except the latter prefaces every string with "EXIT_" and the former
>> uses "SUCCESS" instead of "NORMAL", and cannot handle an invalid exit
>> code. exit_codestring() is not currently used in active code (it's for
>> multi-stream), so its values can be changed to allow the exit_strings
>> array to be removed.
>
> Looks good. You need to add your signoff on these things, i.e.:
> Signed-off-by: Bill Kendall<wkendall at sgi.com>
> We follow the signoff process used in the Linux kernel. See
> sections 12-14 in this document:
> https://github.com/torvalds/linux/blob/master/Documentation/SubmittingPatches
>
>
> Reviewed-by: Alex Elder<aeldre at sgi.com>
>
Sorry, forgot the --signoff when formatting the patch. Need me to
resubmit?
Bill
More information about the xfs
mailing list