[PATCH] Return -EIO when xfs_vn_getattr() failed

Alex Elder aelder at sgi.com
Mon Sep 19 11:54:37 CDT 2011


On Sat, 2011-09-17 at 22:38 +0900, Mitsuo Hayasaka wrote:
> An attribute of inode can be fetched via xfs_vn_getattr() in XFS.
> Currently it returns EIO, not negative value, when it failed.
> As a result, the system call returns not negative value even though
> an error occured. The stat(2), ls and mv commands cannot handle this
> error and do not work correctly.
> 
> This patch fixes this bug, and returns -EIO, not EIO when an error
> is detected in xfs_vn_getattr().
> 
> Signed-off-by: Mitsuo Hayasaka <mitsuo.hayasaka.hu at hitachi.com>
> Cc: Alex Elder <aelder at sgi.com>
> Cc: Christoph Hellwig <hch at infradead.org>

Looks good.

Reviewed-by: Alex Elder <aelder at sgi.com>





More information about the xfs mailing list