[PATCH 1/8] xfstests: fsstress should kill children tasks before exit

Christoph Hellwig hch at infradead.org
Mon Oct 24 04:06:45 CDT 2011


> +int 		should_stop = 0;

this should use sig_atomic_t, or at least volatile.
>  
>  void	add_to_flist(int, int, int);
>  void	append_pathname(pathname_t *, char *);
> @@ -253,6 +256,10 @@ void	usage(void);
>  void	write_freq(void);
>  void	zero_freq(void);
>  
> +void sg_handler(int signum) {
> +	should_stop = 1;
> +}

please use normal K&R / Linux style brace placement.




More information about the xfs mailing list