[PATCH 3/3] 266: Functional test case for the btrfs raid operations

Anand Jain anand.jain at oracle.com
Thu Oct 20 10:32:47 CDT 2011


On 19/10/2011 17:45, Christoph Hellwig wrote:
>> +    if [ $dev_removed == 1 ]; then
>> +	umount $SCRATCH_MNT
>> +        _devmgt_add "${DEVHTL}"
>> +    fi
> 
> messy indendation.

  got it. thanks.

>> +	btrfs filesystem balance $SCRATCH_MNT || _fail "balance failed"
>> +	#btrfs filesystem show $SCRATCH_DEV 2>&1 | egrep devid |awk '{
>> +	#	if ( $6 == "0.00" ) { exit 1 }
>> +	#}' || _fail "test6_add... failed"
> 
> what is the point of the commented out code?
> 
> otherwise looks good to me.

  yes that has to be removed.




More information about the xfs mailing list