[PATCH 1/2] xfstests: make 225 use SCRATCH_DEV

Alex Elder aelder at sgi.com
Thu Oct 13 05:35:33 CDT 2011


On Mon, 2011-10-10 at 13:14 +1100, Dave Chinner wrote:
> From: Dave Chinner <dchinner at redhat.com>
> 
> Use the scratch device for test 225 so that both custom mkfs and
> mount options impact the test (e.g. filesystem block size). This
> exposes test failures when using 512 byte block sizes, which
> currently not tested unless the test device is specifically created
> with a 512 byte block size.
> 
> Also clean up the file names to include the test number, and don't
> remove the test files after the test has finished so that it leaves
> behind a corpse that can be dissected when the test fails.
> 
> Signed-off-by: Dave Chinner <dchinner at redhat.com>

Looks good.

Reviewed-by: Alex Elder <aelder at sgi.com>





More information about the xfs mailing list