[PATCH 2/4] xfs: remove the unused ilock_nowait codepath in writepage

Alex Elder aelder at sgi.com
Tue May 24 21:18:57 CDT 2011


On Thu, 2011-04-28 at 08:55 -0400, Christoph Hellwig wrote:
> wbc->nonblocking is never set, so this whole code has been unreachable
> for a long time.  I'm also not sure it would make a lot of sense -
> we'd rather finish our writeout after a short wait for the ilock
> instead of cancelling the whole ioend.
> 
> Signed-off-by: Christoph Hellwig <hch at lst.de>

Looks good.

Reviewed-by: Alex Elder <aelder at sgi.com>

I'll continue tomorrow on the next one; it'll take a
bit more time to review.




More information about the xfs mailing list