[PATCH] xfsprogs: fix open_by_handle memory leak

Christoph Hellwig hch at infradead.org
Mon May 9 09:06:57 CDT 2011


On Fri, May 06, 2011 at 11:42:57AM -0500, Bill Kendall wrote:
> open_by_handle() calls handle_to_fshandle() which
> allocates an fshandle on the heap, which is never
> freed by open_by_handle(). There is no need to
> call handle_to_fshandle() though, just pass the
> fhandle (rather than fshandle) to handle_to_fsfd(),
> like the other *_by_handle() functions do.
> 
> Signed-off-by: Bill Kendall <wkendall at sgi.com>

Looks good,

Reviewed-by: Christoph Hellwig <hch at lst.de>




More information about the xfs mailing list