[PATCH] xfstests: clean up fallocate configuration tests

Alex Elder aelder at sgi.com
Tue May 3 12:38:43 CDT 2011


On Mon, 2011-05-02 at 19:15 -0500, Eric Sandeen wrote:
> When I added fallocate support to fsx I inadvertently added
> a duplicate fallocate test.
> 
> Consolidate them both into one test (the link test, not the
> compile test) and make all tests use "true" rather than "yes"
> to be more consistent with other tests.

Looks reasonable to me.  I learned a little something
about autoconf while looking at this.  Glad you're an
expert :)

I do see that AC_TRY_COMPILE() is now considered obsolete
so at some point maybe we should update to use the suggested
alternatives (AC_COMPILE_IFELSE() in this example).

Reviewed-by: Alex Elder <aelder at sgi.com>

> Signed-off-by: Eric Sandeen <sandeen at sandeen.net>





More information about the xfs mailing list