[PATCH 1/2] xfstests: a few fixes to Makefile

Christoph Hellwig hch at infradead.org
Fri Mar 11 04:10:20 CST 2011


On Thu, Mar 10, 2011 at 04:16:06PM -0600, Alex Elder wrote:
> On Thu, 2011-03-10 at 12:25 -0500, Christoph Hellwig wrote:
> > > +ifeq ($(HAVE_DMAPI), true)
> > >  	# automake doesn't always support "default" target 
> > >  	# so do dmapi make explicitly with "all"
> > > -ifeq ($(HAVE_DMAPI), true)
> > 
> > What about moving the # signs to the first line so that it never gets
> > echoed at all?
> > 
> > Otherwise looks good to me.
> 
> That would work too.  A later patch makes the
> whole thing go away though, so it's sort of moot.
> (And I already committed it after some discussion
> with Eric yesterday...)

Ok.




More information about the xfs mailing list