[PATCH 2/2] xfstests: some refinements on "make depend"
aelder at sgi.com
Thu Mar 10 16:09:36 CST 2011
On Thu, 2011-03-10 at 12:26 -0500, Christoph Hellwig wrote:
> On Fri, Mar 04, 2011 at 01:37:41PM -0600, Alex Elder wrote:
> > Make it so "make depend" is a generic target, like "make clean".
> > Each Makefile has a "depend" target that indicates whether making
> > dependencies means creating ".dep" or creating ".ltdep" (or, I
> > suppose, both, though none do that right now). Both files get
> > created even if there are no CFILES to scan (to ensure the target
> > up-to-date). The "default" target now depends on "depend" (there is
> > no "ltdepend" any more).
> > Remove the "depend" and "ltdepend" definitions from the "buildrules"
> > file; only the actual generated files (".dep" and ".ltdep") remain
> > as generic targets. The "depend' target is still defined as phony.
> > Do a shell trick when expanding the value of CFILES, to avoid a
> > problem that occurs if it is created by "make" by concatentating two
> > empty strings. The problem was that in that case CFILES will
> > contain a space, and that wasn't getting treated as empty as
> > desired.
> > Make the rule for tool/lib dependencies more generic, to reflect the
> > general desire that "lib" subdirectories need to be built before
> > things in the "tool" subdirectories.
> Can we instead port over the generic dependency generation from
My intention was to work toward unifying all the user space
stuff, basically in line with what you suggest.
This is part of a flurry of changes related to the xfstests
dmapi subtree. One of the things I needed to do was populate
a set of new Makefiles there, and I guess in looking into
that I found I didn't like the way the dependencies were done,
and the changes I made to address that ended up in this patch.
I'll hold off on this patch and will reconsider it once
I get the more substantive dmapi changes in.
More information about the xfs