[PATCH 0/3] xfsprogs: sync up with 2.6.38 kernel code V2
Christoph Hellwig
hch at infradead.org
Mon Mar 7 12:24:31 CST 2011
On Mon, Mar 07, 2011 at 12:14:44PM -0600, Alex Elder wrote:
> 3) Why are you dropping the use of the symbols
> XFS_DINODE_VERSION_1 and XFS_DINODE_VERSION_2 in
> favor of just using 1 and 2? (I guess I'm OK with
> it, but wanted to call it out anyway.)
Because we dropped them from the kernel a while ago. The removal
in kernel land was my patch and the reason is that it simply doesn't buy
anything over using the numerical constants.
> - XFS_IOC_FREEZE and XFS_IOC_THAW are still defined in
> this version. The code that uses it here could possibly
> be converted to use the Linux generic FIFREEZE and FITHAW
> instead.
That would require all users to include <linux/fs.h> first.
More information about the xfs
mailing list