[PATCH]: [xfstests] Make the requirement of projid32bit explicit in test 244

Chandra Seetharaman sekharan at us.ibm.com
Tue Jun 14 20:10:06 CDT 2011


Test 244 depends on projid32bit feature in mkfs.xfs. Not all versions
of xfsprogs provide that feature in mkfs.xfs.

This patch makes it an explicit requirement and avoids running the test
if the feature doesn't exist, instead of failing the test with an obscure
message.

Signed-Off-By: Chandra Seetharaman <sekharan at us.ibm.com>
---
diff --git a/244 b/244
index 99762a5..e9f8a3d 100755
--- a/244
+++ b/244
@@ -48,6 +48,7 @@ _cleanup()
 _supported_fs xfs
 _require_xfs_quota
 _require_scratch
+_require_projid32bit_in_xfs
 
 export MOUNT_OPTIONS="-opquota"
 
diff --git a/common.rc b/common.rc
index c510c66..4e051dc 100644
--- a/common.rc
+++ b/common.rc
@@ -797,6 +797,15 @@ _require_command()
     [ -n "$1" -a -x "$1" ] || _notrun "$_cmd utility required, skipped this test"
 }
 
+# this test requires the projid32bit feature to be available in
+# mkfs.xfs
+#
+_require_projid32bit_in_xfs()
+{
+        _scratch_mkfs_xfs -f -i projid32bit=0 2>&1 >/dev/null \
+	   || _notrun "mkfs.xfs doesn't have projid32bit feature"
+}
+
 # this test requires that external log/realtime devices are not in use
 #
 _require_nonexternal()





More information about the xfs mailing list