[PATCH] xfs: Fix wrong return value of xfs_file_aio_write

Alex Elder aelder at sgi.com
Tue Jul 26 10:21:48 CDT 2011


On Sun, 2011-07-24 at 14:03 +0200, Markus Trippelsdorf wrote:
> The fsync prototype change commit 02c24a82187d accidentally overwrote
> the ssize_t return value of xfs_file_aio_write with 0 for SYNC type
> writes. Fix this by checking if an error occured when calling
> xfs_file_fsync and only change the return value in this case.
> In addition xfs_file_fsync actually returns a normal negative error, so
> fix this, too.
> 
> Signed-off-by: Markus Trippelsdorf <markus at trippelsdorf.de>
> Reviewed-by: Christoph Hellwig <hch at lst.de>
> Tested-by: Christoph Hellwig <hch at lst.de>

Finally looking at this I noticed the same thing Christoph
did; thanks for fixing both.  Your change got committed
yesterday via Al Viro's VFS tree.

					-Alex




More information about the xfs mailing list