[PATCH 02/12 v3] xfs: Remove the macro XFS_BUF_ZEROFLAGS

Christoph Hellwig hch at infradead.org
Sun Jul 24 06:39:59 CDT 2011


> @@ -1247,6 +1247,7 @@ xlog_bdstrat(
>  {
>  	struct xlog_in_core	*iclog = bp->b_fspriv;
>  
> +	bp->b_flags &= ~(XBF_FUA|XBF_FLUSH);

I don't think this is correct, we set these before calling into
xlog_bdstrat, so this means we'll always stip it off after that.

Given that this area is more complicated than the pure macro removal
how about letting it as-is for now?  I have some bigger refactoring
in this area in my queue, and I'll just incorporate the
XFS_BUF_ZEROFLAGS into it.




More information about the xfs mailing list