[PATCH] xfstests: fix modulo-by-zero error in fsx
Christoph Hellwig
hch at infradead.org
Tue Jul 19 12:10:54 CDT 2011
On Tue, Jul 19, 2011 at 01:49:13PM +1000, Dave Chinner wrote:
> From: Dave Chinner <dchinner at redhat.com>
>
> The recent fsx fixes has a logic error in the offset trimming code.
> If a read is done when the file size is zero, then the logic error
> causes a offset % 0 opertaion to occur. This causes fsx to get a
> SIGFPE and die.
>
> This was not discovered during my testing because I was using a
> random seed that didn't trip this condition. Changing the seed to
> that which test 091 uses (the default of 1) causes such an operation
> to occur....
Looks good,
Reviewed-by: Christoph Hellwig <hch at lst.de>
More information about the xfs
mailing list