[PATCH 07/12] xfs: Remove the macro XFS_BUF_PTR

Christoph Hellwig hch at infradead.org
Sat Jul 16 12:03:52 CDT 2011


> -			memcpy((char *)dabuf->data + off, XFS_BUF_PTR(bp),
> +			memcpy((char *)dabuf->data + off, bp->b_addr,
>  				XFS_BUF_COUNT(bp));
>  		}
>  	}
> @@ -2317,7 +2317,7 @@ xfs_da_buf_clean(xfs_dabuf_t *dabuf)
>  		for (i = off = 0; i < dabuf->nbuf;
>  				i++, off += XFS_BUF_COUNT(bp)) {
>  			bp = dabuf->bps[i];
> -			memcpy(XFS_BUF_PTR(bp), (char *)dabuf->data + off,
> +			memcpy(bp->b_addr, (char *)dabuf->data + off,
>  				XFS_BUF_COUNT(bp));

While not strictly related it would be nice to kill tha (char *) casts
here while you're at it.

Otherwise the patch looks go,

Reviewed-by: Christoph Hellwig <hch at lst.de>




More information about the xfs mailing list