[PATCH 19/27] xfs: kill struct xfs_dir2_data

[Dave Chinner]

On Fri, Jul 01, 2011 at 05:43:40AM -0400, Christoph Hellwig wrote:
> Remove the confusing xfs_dir2_data structure.  It is supposed to describe
> an XFS dir2 data btree block, but due to the variable sized nature of
> almost all elements in it it can't actuall do anything close to that
> job.  In addition to accessing the fixed offset header structure it was
> only used to get a pointer to the first dir or unused entry after it,
> which can be trivially replaced by pointer arithmetics on the header
> pointer.  For most users that is actually more natural anyway, as they
> don't use a typed pointer but rather a character pointer for further
> arithmetics.
> 
> Signed-off-by: Christoph Hellwig <hch at lst.de>
> 
> @@ -70,10 +69,9 @@ xfs_dir2_data_check(
>  	struct xfs_name		name;
>  
>  	mp = dp->i_mount;
> -	d = bp->data;
> -	hdr = &d->hdr;
> +	hdr = bp->data;
>  	bf = hdr->bestfree;
> -	p = (char *)d->u;
> +	p = (char *)(hdr + 1);

Same comment as the previous patch about using a wrapper for this.

Otherwise looks fine.

Reviewed-by: Dave Chinner <dchinner at redhat.com>

-- 
Dave Chinner
david at fromorbit.com