[PATCH 7/8] xfs: handle CIl transaction commit failures correctly

Christoph Hellwig hch at infradead.org
Tue Jan 25 03:53:21 CST 2011


On Tue, Jan 25, 2011 at 07:50:43PM +1100, Dave Chinner wrote:
> From: Dave Chinner <dchinner at redhat.com>
> 
> Failure to commit a transaction into the CIL is not handled
> correctly. This currently can only happen when racing with a
> shutdown and requires an explicit shutdown check, so it rare and can
> be avoided. Remove the shutdown check and make the CIL commit a void
> function to indicate it will always succeed, thereby removing the
> incorrectly handled failure case.

Looks good,

Reviewed-by: Christoph Hellwig <hch at lst.de>




More information about the xfs mailing list