[PATCH] xfs: add FITRIM support

Christoph Hellwig hch at infradead.org
Thu Jan 6 12:03:05 CST 2011


> > + * Copyright (C) 2010 Red Hat, Inc.
> 
> Maybe 2011 now...

Nothing major changes in 2011, so no.

> > +		 * If the extent is entirely outside of the range we are
> > +		 * supposed to discard skip it.  Do not bother to trim
> > +		 * down partially overlapping ranges for now.
> > +		 */
> > +		if (XFS_AGB_TO_FSB(mp, agno, fbno) + flen < start ||
> > +		    XFS_AGB_TO_FSB(mp, agno, fbno) > start + len) {
> 
>                                                     ^
>                                           I think this should be >=

Yes.

> Do you want to add a boilerplate copyright header here?

Kinda hard to claim copyright on a single prototype.




More information about the xfs mailing list