[XFS updates] XFS development tree branch, for-linus, updated. v2.6.37-rc4-10837-gbe71514

xfs at oss.sgi.com xfs at oss.sgi.com
Tue Feb 22 21:01:33 CST 2011


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "XFS development tree".

The branch, for-linus has been updated
  be71514 xfs: check if device support discard in xfs_ioc_trim()
  3a3675b xfs: prevent leaking uninitialized stack memory in FSGEOMETRY_V1
      from  24446fc66fdebbdd8baca0f44fd2a47ad77ba580 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit be715140b5c3baf8ab6708060cfab80bef279d18
Author: Lukas Czerner <lczerner at redhat.com>
Date:   Tue Feb 15 17:07:36 2011 +0000

    xfs: check if device support discard in xfs_ioc_trim()
    
    Right now we, are relying on the fact that when we attempt to
    actually do the discard, blkdev_issue_discar() returns -EOPNOTSUPP
    and the user is informed that the device does not support discard.
    
    However, in the case where the we do not hit any suitable free
    extent to trim in FITRIM code, it will finish without any error.
    This is very confusing, because it seems that FITRIM was successful
    even though the device does not actually supports discard.
    
    Solution: Check for the discard support before attempt to search for
    free extents.
    
    Signed-off-by: Lukas Czerner <lczerner at redhat.com>
    Signed-off-by: Alex Elder <aelder at sgi.com>

commit 3a3675b7f23f83ca8c67c9c2b6edf707fd28d1ba
Author: Dan Rosenberg <drosenberg at vsecurity.com>
Date:   Mon Feb 14 13:45:28 2011 +0000

    xfs: prevent leaking uninitialized stack memory in FSGEOMETRY_V1
    
    The FSGEOMETRY_V1 ioctl (and its compat equivalent) calls out to
    xfs_fs_geometry() with a version number of 3.  This code path does not
    fill in the logsunit member of the passed xfs_fsop_geom_t, leading to
    the leaking of four bytes of uninitialized stack data to potentially
    unprivileged callers.
    
    v2 switches to memset() to avoid future issues if structure members
    change, on suggestion of Dave Chinner.
    
    Signed-off-by: Dan Rosenberg <drosenberg at vsecurity.com>
    Reviewed-by: Eugene Teo <eugeneteo at kernel.org>
    Signed-off-by: Alex Elder <aelder at sgi.com>

-----------------------------------------------------------------------

Summary of changes:
 fs/xfs/linux-2.6/xfs_discard.c |    2 ++
 fs/xfs/xfs_fsops.c             |    3 +++
 2 files changed, 5 insertions(+), 0 deletions(-)


hooks/post-receive
-- 
XFS development tree




More information about the xfs mailing list