[PATCH 07/11] xfs: replace i_pin_wait with a bit waitqueue
Dave Chinner
david at fromorbit.com
Tue Dec 13 16:21:58 CST 2011
On Thu, Dec 08, 2011 at 10:58:02AM -0500, Christoph Hellwig wrote:
> Replace i_pin_wait, which is only used during synchronous inode flushing
> with a bit waitqueue. This trades off a much smaller inode against
> slightly slower wakeup performance, and saves 12 (32-bit) or 20 (64-bit)
> bytes in the XFS inode.
>
> Signed-off-by: Christoph Hellwig <hch at lst.de>
> Reviewed-by: Alex Elder <aelder at sgi.com>
Looks fine - the pinning code never modifies the i_flags field, so
doesn't require the i_flags_lock anywhere so the concerns i had
about the previous patch are not relevant here...
Reviewed-by: Dave Chinner <dchinner at redhat.com>
--
Dave Chinner
david at fromorbit.com
More information about the xfs
mailing list