[patch 05/19] xfs: make sure to really flush all dquots in xfs_qm_quotacheck

Ben Myers bpm at sgi.com
Thu Dec 8 15:36:43 CST 2011


On Tue, Dec 06, 2011 at 04:58:11PM -0500, Christoph Hellwig wrote:
> Make sure we do not skip any dquots when flushing them out after a
> quotacheck to make sure that we will never have any dirty dquots on a
> live filesystem.  At this point no dquot should be pinnable, but lets
> be pedantic about it.
> 
> Signed-off-by: Christoph Hellwig <hch at lst.de>
> Reviewed-by: Dave Chinner <dchinner at redhat.com>

Reviewed-by: Ben Myers <bpm at sgi.com>
 
> ---
>  fs/xfs/xfs_qm.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Index: xfs/fs/xfs/xfs_qm.c
> ===================================================================
> --- xfs.orig/fs/xfs/xfs_qm.c	2011-11-25 11:45:32.672075575 +0100
> +++ xfs/fs/xfs/xfs_qm.c	2011-11-25 11:45:35.875391556 +0100
> @@ -1661,7 +1661,7 @@ xfs_qm_quotacheck(
>  	 * successfully.
>  	 */
>  	if (!error)
> -		error = xfs_qm_dqflush_all(mp, SYNC_TRYLOCK);
> +		error = xfs_qm_dqflush_all(mp, 0);

It's hard to know what 0 means here, but I also see what's coming up in
your series.




More information about the xfs mailing list