[PATCH] xfstests: check if qa user can execute commands

Christoph Hellwig hch at infradead.org
Tue Dec 6 09:13:00 CST 2011


On Tue, Dec 06, 2011 at 10:56:29AM +0100, Jan Schmidt wrote:
> _require_user only checks if the qa user exists in /etc/passwd. It may exist
> though still not be able to execute anything (e.g. with a /bin/false shell).
> 
> _user_do cannot determine failure to execute the given command, as it uses
> _user_do_filter for post-processing which succeeds even if the command
> fails. Thus, the check should be performed by _require_user.

Looks good.  Wouldn't

	su $qa_user -c /bin/true

be the more normal way to write that test?




More information about the xfs mailing list