[PATCH 09/16] xfs: flatten the dquot lock ordering

Dave Chinner david at fromorbit.com
Mon Dec 5 18:25:11 CST 2011


On Mon, Dec 05, 2011 at 06:50:21AM -0500, Christoph Hellwig wrote:
> On Mon, Dec 05, 2011 at 08:34:37PM +1100, Dave Chinner wrote:
> > Hmmmm. My unmodified tree just has the declaration without
> > initialisation, and I didn't find any place where the initialisation
> > was added in the preceding patches. I'll go back and have another
> > look.
> 
> It's actually in this patch:
> 
> @@ -489,8 +498,8 @@ xfs_qm_dqpurge_int(
>         struct xfs_quotainfo    *q = mp->m_quotainfo;
> 	struct xfs_dquot        *dqp, *n;
> 	uint                    dqtype;
> -       int                     nrecl;
> -       int                     nmisses;
> +       int			nmisses = 0;
> +       LIST_HEAD		(dispose_list);
> 

OK, so I'm blind. :/

Move along, nothing to see here....

Cheers,

Dave.
-- 
Dave Chinner
david at fromorbit.com




More information about the xfs mailing list