[PATCH 1/4] xfs: Don't allocate new buffers on every call to _xfs_buf_find
Alex Elder
aelder at sgi.com
Fri Aug 26 09:19:48 CDT 2011
On Fri, 2011-08-26 at 04:11 -0400, Christoph Hellwig wrote:
. . .
> >
> > +found:
> > + ASSERT(bp->b_flags & XBF_MAPPED);
>
> This doesn't look right to me. Various buffers like inode or remoate attrs
> are unmapped, and I can't see any reason why we would assert not beeing
> allowed to find them here.
>
> Thinking about it more I'm also not sure skipping the code to map
> buffers on a straight cache hit is a good idea - there's nothing
> inherent to requiring a given buffer to be mapped for all callers.
I actually tripped this assert last night the first time I
tried running it.
-Alex
More information about the xfs
mailing list