[PATCH, RFC] xfs: deprecate the nodelaylog mount option

[Dave Chinner]

On Wed, Aug 24, 2011 at 01:57:51AM -0400, Christoph Hellwig wrote:
> Signed-off-by: Christoph Hellwig <hch at lst.de>
> 
> Index: xfs/Documentation/feature-removal-schedule.txt
> ===================================================================
> --- xfs.orig/Documentation/feature-removal-schedule.txt	2011-08-24 07:45:56.450196165 +0200
> +++ xfs/Documentation/feature-removal-schedule.txt	2011-08-24 07:47:17.049759519 +0200
> @@ -592,3 +592,11 @@ Why:    In 3.0, we can now autodetect in
>  	interface that was used by acer-wmi driver. It will replaced by
>  	information log when acer-wmi initial.
>  Who:    Lee, Chun-Yi <jlee at novell.com>
> +
> +----------------------------
> +What:	The XFS nodelaylog mount option
> +When:	3.3
> +Why:	The delaylog mode that has been the default since 2.6.39 has proven
> +	stable, and the old code is in the way of additional improvements in
> +	the log code.
> +Who:	Christoph Hellwig <hch at lst.de>
> Index: xfs/fs/xfs/xfs_super.c
> ===================================================================
> --- xfs.orig/fs/xfs/xfs_super.c	2011-08-24 07:47:53.696227656 +0200
> +++ xfs/fs/xfs/xfs_super.c	2011-08-24 07:48:53.249238363 +0200
> @@ -356,6 +356,8 @@ xfs_parseargs(
>  			mp->m_flags |= XFS_MOUNT_DELAYLOG;
>  		} else if (!strcmp(this_char, MNTOPT_NODELAYLOG)) {
>  			mp->m_flags &= ~XFS_MOUNT_DELAYLOG;
> +			xfs_warn(mp,
> +	"nodelaylog is deprecated and will be removed in Linux 3.3");
>  		} else if (!strcmp(this_char, MNTOPT_DISCARD)) {
>  			mp->m_flags |= XFS_MOUNT_DISCARD;
>  		} else if (!strcmp(this_char, MNTOPT_NODISCARD)) {

No argument here. Getting rid of the old transaction commit code
would both siginficantly cleanup the code and enable lots of
interesting transaction optimisations to be made....

So it gets my thumbs-up.

Reviewed-by: Dave Chinner <dchinner at redhat.com>

Cheers,

Dave.
-- 
Dave Chinner
david at fromorbit.com