Btw, one interesting thing I noticed is that xfs_attr_leaf_create always zeroes and logs whe whole attr block. I'll need to audit this a bit more, but from the highlevel POV I don't see why we can't simply just logs the bits we actually added.