[PATCH 3/6] xfs: move more delwri setup into xfs_buf_delwri_queue

Dave Chinner david at fromorbit.com
Mon Aug 22 01:19:27 CDT 2011


On Sun, Aug 14, 2011 at 01:15:20PM -0400, Christoph Hellwig wrote:
> Do not transfer a reference held by the caller to the buffer on the list,
> or decrement it in xfs_buf_delwri_queue, but instead grab a new reference
> if needed, and let the caller drop its own reference.  Also move setting
> of the XBF_DELWRI and XBF_ASYNC flags into xfs_buf_delwri_queue, and
> only do it if needed.  Note that for now xfs_buf_unlock already has
> XBF_DELWRI, but that will change in the following patches.
> 
> Signed-off-by: Christoph Hellwig <hch at lst.de>

Yup, the transfer of refcounts was messy. Much better to have the
delwri queue manage it's own refcount.

Reviewed-by: Dave Chinner <dchinner at redhat.com>
-- 
Dave Chinner
david at fromorbit.com




More information about the xfs mailing list