[PATCH v2 6/7] xfsdump: convert to the POSIX signal API

Christoph Hellwig hch at infradead.org
Fri Aug 12 15:45:54 CDT 2011


On Fri, Aug 12, 2011 at 02:15:58PM -0500, Bill Kendall wrote:
> >Is there any requirement that the fields
> >other than sa_flags and sa_handler should
> >be zeroed before use?
> 
> The sa_sigaction field will only be used if sa_flags
> has SA_SIGINFO set, and the sa_restored field is obsolete
> and not specified by POSIX. Better to explicitly initialize
> everything though, so I'll change that.

sigaction actuall is a rare case where this is harmful.  To quote
the manpage:

	On some architectures a union is involved:  do not assign to both
	sa_handler and sa_sigaction.




More information about the xfs mailing list