[PATCH v3 1/2] xfstests: make more tests generic
Alex Elder
aelder at sgi.com
Wed Aug 10 11:38:43 CDT 2011
On Wed, 2011-08-10 at 12:33 -0400, Christoph Hellwig wrote:
> On Wed, Aug 10, 2011 at 05:52:14PM +0200, David Sterba wrote:
> > there's a hardcoded path for mkfs.btrfs in common.rc:_scratch_mkfs_sized()
> >
> > 335 btrfs)
> > 336 /sbin/mkfs.$FSTYP $MKFS_OPTIONS $SCRATCH_DEV -b $fssize
> > 337 ;;
> >
> > I have a /usr/local/ installation of btrfsprogs from git,
> > _scratch_mkfs_sized() was not called for btrfs before.
> >
> > Possible ways to fix this:
> > 1) use /sbin/mkfs -t $FSTYP like _scratch_mkfs, or
> > 2) set $MKFS_BTRFS_PROG like for some other filesystems
> >
> >
> > What is preferred?
>
> Please send a patch for variant 2. As soon as we have option using
> the generic mkfs wrapper sounds like a good idea. In addition to that
> treating btrfs the same way as other filesystems is always good.
Whoops, we gave different answers. Do what Christoph says... -Alex
More information about the xfs
mailing list