[PATCH] xfs: fix compiler warning in xfs_trace.h

Dave Chinner david at fromorbit.com
Wed Apr 27 21:20:36 CDT 2011


On Sun, Apr 24, 2011 at 03:02:58PM -0400, Christoph Hellwig wrote:
> xfs_fsblock_t may be a 32-bit type on if XFS_BIG_BLKNOS is not set,
> make sure to cast a value of this type to an unsigned long long
> before using the ll printk qualifier.
> 
> Reported-by: Randy Dunlap <randy.dunlap at oracle.com>
> Signed-off-by: Christoph Hellwig <hch at lst.de>
> 
> Index: xfs/fs/xfs/linux-2.6/xfs_trace.h
> ===================================================================
> --- xfs.orig/fs/xfs/linux-2.6/xfs_trace.h	2011-04-22 06:22:11.409709360 +0200
> +++ xfs/fs/xfs/linux-2.6/xfs_trace.h	2011-04-22 06:22:30.756271218 +0200
> @@ -1418,7 +1418,7 @@ DECLARE_EVENT_CLASS(xfs_alloc_class,
>  		  __entry->wasfromfl,
>  		  __entry->isfl,
>  		  __entry->userdata,
> -		  __entry->firstblock)
> +		  (unsigned long long)__entry->firstblock)
>  )
>  
>  #define DEFINE_ALLOC_EVENT(name) \

Reviewed-by: Dave Chinner <dchinner at redhat.com>

-- 
Dave Chinner
david at fromorbit.com




More information about the xfs mailing list