[PATCH 8/9] xfs: catch bad block numbers freeing extents.

Christoph Hellwig hch at infradead.org
Wed Apr 6 08:59:51 CDT 2011


> +	/* validate the extent size is legal now we have the agf locked */
> +	if (!args.agbp) {
> +		error = EFSCORRUPTED;
> +		goto error0;
> +	}

This is not a corruption case, but would require someone changing
xfs_fix_freelist and messing up.  I think the check can be removed
given that the potentially added bug would trivially trip up as
a NULL pointer dereference.

Otherwise looks good,

Reviewed-by: Christoph Hellwig <hch at lst.de>




More information about the xfs mailing list