[PATCH] xfs: fix variable set but not used warnings
Christoph Hellwig
hch at infradead.org
Tue Apr 5 14:10:06 CDT 2011
On Mon, Apr 04, 2011 at 01:21:20PM -0500, Alex Elder wrote:
> > __int64_t sbflags;
> >
> > flags &= (XFS_ALL_QUOTA_ACCT | XFS_ALL_QUOTA_ENFD);
> > /*
> > * Switching on quota accounting must be done at mount time.
> > */
> > - accflags = flags & XFS_ALL_QUOTA_ACCT;
> > flags &= ~(XFS_ALL_QUOTA_ACCT);
>
> Unrelated, but isn't the effect of this line plus the one a few
> lines up the same as this?
>
> flags &= XFS_ALL_QUOTA_ENFD;
Yes, it is. I have a patch in my queue to clean this and a few others
bits around it up, but unlike the warnings fixes it's really 2.6.40
material.
More information about the xfs
mailing list