[PATCH 3/3] [PATCH 3/3] xfs: do not use xfs_mod_incore_sb_batch for per-cpu counters
Dave Chinner
david at fromorbit.com
Wed Sep 29 06:27:20 CDT 2010
On Wed, Sep 29, 2010 at 03:22:24AM -0400, Christoph Hellwig wrote:
> Update the per-cpu counters manually in xfs_trans_unreserve_and_mod_sb and
> remove support for per-cpu counters from xfs_mod_incore_sb_batch to
> simplify it. And added benefit is that we don't have to take m_sb_lock
> for transactions that only modify per-cpu counters.
>
> Signed-off-by: Christoph Hellwig <hch at lst.de>
....
> +
> + return;
> +
> +out_undo_ifreecount:
> + if (ifreedelta)
> + xfs_icsb_modify_counters(mp, XFS_SBS_IFREE, ifreedelta, rsvd);
> +out_undo_icount:
> + if (idelta)
> + xfs_icsb_modify_counters(mp, XFS_SBS_ICOUNT, idelta, rsvd);
These two should be -ifreedelta and -idelta, right?
Cheers,
Dave.
--
Dave Chinner
david at fromorbit.com
More information about the xfs
mailing list